Skip to content

chore: mark methods in Protocol definitions as abstract#138

Merged
QuantumGhost merged 9 commits into
langgenius:mainfrom
QuantumGhost:type/static-assertion
May 18, 2026
Merged

chore: mark methods in Protocol definitions as abstract#138
QuantumGhost merged 9 commits into
langgenius:mainfrom
QuantumGhost:type/static-assertion

Conversation

@QuantumGhost
Copy link
Copy Markdown
Contributor

@QuantumGhost QuantumGhost commented May 13, 2026 •
edited
Loading

AI disclosure: This PR was primarily drafted with Codex using GPT-5.5.
I have reviewed and edited the final diff, and I am responsible for the content.

Important

  1. Make sure you have read our contribution guidelines
  2. Search existing issues and pull requests to confirm this change is not a duplicate
  3. Open or identify the issue this pull request resolves or advances
  4. Use a Conventional Commits title for this pull request, and mark breaking changes with !
  5. Remember that the pull request title will become the squash merge commit message
  6. If CLA Assistant prompts you, sign CLA.md in the pull request conversation

Related Issue

Closes #136

Summary

This PR hardens protocol contracts by:

  1. Preventing nominal subclasses from inadvertently becoming instantiable unless they explicitly override the protocol methods.

Changes included:

  • Marks protocol methods as abstract.
  • Adds regression tests for abstract protocol methods.

Validation performed:

  • make check
  • uv run pytest
  • uv build --out-dir /tmp/graphon-dist.FoJno3

Checklist

  • This pull request links the issue it resolves or advances
  • This pull request title follows Conventional Commits, and any breaking change is marked with !
  • If CLA Assistant prompted me, I signed CLA.md in the pull request conversation

@QuantumGhost
chore: move static type assertion into dedicated file
c0141da
@QuantumGhost
chore: mark methods for Protocol definitions as abstract
8450ee4 
Assisted-By: Codex:GPT-5.5
@QuantumGhost
chore: introduce static assertions for Protocol implementations
8c48315 
Assisted-By: Codex:GPT-5.5
@QuantumGhost
chore: harden Protocol contract checks
85434b0 
Exclude static type contract modules from published distributions and document their development-only role.

Add tests that ensure Protocol methods remain abstract enough to reject indirect nominal implementations without overrides.

Assisted-by: Codex:GPT-5.4
@QuantumGhost QuantumGhost mentioned this pull request May 13, 2026
Closed
@QuantumGhost
test: discover Protocol abstract contracts
6df3e22 
Replace the hand-maintained Protocol list with AST-based discovery over graphon modules so new Protocol definitions are automatically covered.

Assisted-by: Codex:GPT-5.4
@QuantumGhost

This comment was marked as outdated.

Sign in to view
@QuantumGhost
chore: trim nominal Protocol type contracts
6907703 
Remove type contract files where the implementation already subclasses the Protocol directly, and document that type contracts are intended for structural implementations.

Assisted-by: Codex:GPT-5.4
@QuantumGhost
Copy link
Copy Markdown
Contributor Author

QuantumGhost commented May 13, 2026

Adjusted the static type contract scope based on review feedback.

Changes:

  • Removed files for implementations that already directly subclass their target Protocol, such as .
  • Kept structural contracts where the implementation does not nominally inherit the target Protocol.
  • For mixed files, retained only the structural assertions.
  • Updated CONTRIBUTING.md to document that type contract files are for structural protocol implementations.

Validation:

  • make check
  • uv run pytest

@QuantumGhost

This comment was marked as outdated.

Sign in to view
@QuantumGhost QuantumGhost mentioned this pull request May 13, 2026
Closed
3 tasks
@QuantumGhost QuantumGhost marked this pull request as ready for review May 13, 2026 16:28
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 13, 2026
@QuantumGhost
test: simplify Protocol abstract contract coverage
0a0f1b1 
Keep the Protocol contract test focused on member abstractness, document the non-empty member guard, and remove direct/indirect instantiation checks.

Assisted-by: Codex:GPT-5.4
@QuantumGhost

This comment was marked as outdated.

Sign in to view
@QuantumGhost QuantumGhost enabled auto-merge (squash) May 13, 2026 16:33
@QuantumGhost QuantumGhost disabled auto-merge May 13, 2026 16:35
@QuantumGhost QuantumGhost enabled auto-merge (squash) May 13, 2026 16:36
@WH-2099 WH-2099 self-assigned this May 15, 2026
@WH-2099 WH-2099 self-requested a review May 15, 2026 08:10
@QuantumGhost QuantumGhost changed the title chore: harden Protocol contract checks chore: mark methods in Protocol definitions as abstract May 18, 2026
@QuantumGhost
chore: remove *_type_contract.py files
0ac7db1 
@WH-2099 suggests removing static assertions as this is unnecessary.
@QuantumGhost QuantumGhost force-pushed the type/static-assertion branch from a002a86 to 0ac7db1 Compare May 18, 2026 00:39
@QuantumGhost QuantumGhost merged commit 8354b14 into langgenius:main May 18, 2026
5 checks passed
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

@WH-2099 WH-2099 Awaiting requested review from WH-2099

Assignees

@WH-2099 WH-2099

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Harden Protocol contracts with abstract methods

3 participants

@QuantumGhost @laipz8200 @WH-2099